Timepicker twelvehours false doesn\’t show 24 hour not

Topic: Timepicker twelvehours false doesn\’t show 24 hour notation in the upper textbox

Starceaker free asked 8 years ago

Dear MDB am testing your mdb-time-picker and see that when I put twelvehour to false that it:

correctly shows the inner and outer circle of hours (1 - 12 and 13-00)
after selecting 13:00 or later it shows the 12 hour notation in the text field on top

This is a blocking problem for anyone using the 24 hour notation and using the 12 hour notation is not an option.

Rafał Rogulski free commented 8 years ago

Thanks, for report this bug we will fix it in next release.

Starceaker free commented 8 years ago

Do you have an ETA for this? This is quite an annoying / somewhat blocking problem.

Rafał Rogulski free commented 8 years ago

No, we w don't have any ETA, but want to add in next release.

Starceaker free commented 8 years ago

Dear Rafal From what I can tell this is not yet fixed in version 4.3.5. In which next release will this be fixed? I'll repeat my previous statement in saying that "this is an annoying / blocking problem.".

Add comment

Dawid Adach pro answered 8 years ago

1 0 Best answer

Please insert min. 20 characters.

Dear Starceaker, My apologies for your inconvenience. We have fixed the problem, it will be available in next release within few days. For now you can apply the hotfix yourself: please replace following code starting from line 294 in timepicker.component.ts file:

} else {
 if (isHours) {
 if (value === 12) {
 value = 0;
 value = inner ? (value === 0 ? 12 : value) : value === 0 ? 0 : value + 12;
 }
 } else {

with following

} else {
 if (isHours) {
 value = !inner? value + 12 : value;
 value = value === 24 ? 0 : value;
 value = (inner && value === 0) ? 12 : value;
 value = (!inner && value === 12) ? 0 : value;
 } else {

Starceaker free commented 8 years ago

Thank you, this does the trick.

Add comment

Adrian Sawicki free answered 8 years ago