Mikołaj Smoleński staff commented 2 years ago

Hello,

We added .npmignore to exclude source files from node_modules to prevent multiple downloads from being unnecessarily. Additionally, it is not good practice to store source files here. At the same time, the files are still available in our repositories, from where they can be downloaded and customized. Is it sufficient in your case?

Keep coding!

VDLP priority commented 2 years ago

Hi,

In our opinion the source files should be included, so our mdb vue and scss are running in sync. Besides the scss variables, we also use the bootstrap scss functions in our own scss files.

It would also be nice to have the source files for the vue, ts and scss files, so a source map can be generated. This helps finding bugs in the original code.

With kind regards,

Van der Let & Partners

Mikołaj Smoleński staff commented 2 years ago

May I ask what the importing process of these files looks like? It is generally not good practice to use anything directly from the node_modules folder, so we currently recommend that you copy these files from the repository. Does it complicate your work on the project? If so, we will of course consider restoring the source files to the library.

Keep coding!

VDLP priority commented 2 years ago

Thanks for your quick response!

Copying the source files directly into our project will complicate matters and adds an extra manual action for us each (minor) update, with the added risk that files are not in sync anymore. Furthermore it makes development more painful as sourcemaps can no longer reference the original source files which makes debugging a lot harder.

The file structure we use in our SCSS files is as follows (simplified):

• Import our own variables file with e.g. color overrides ($primary, $link-color etc), breakpoint changes ($grid-breakpoints) and spacer alterations ($spacers). We also overrule the $utilities variable so that we can add some more helper classes generated automatically by bootstrap. We also alter some MDB variables like '$form-outline-select-label-color' and '$datepicker-header-background-color' (we override more, those are just an example)
• Import MDB (with bootstrap included automatically)
• Import our own custom SCSS files. These files also use Bootstrap functions like 'media-breakpoint-up' , 'color-contrast' etc. Without the source files, we would be unable to use these functions provided by bootstrap / MDB.

Mikołaj Smoleński staff commented 2 years ago

Thanks for the clarification.

Will it be enough for you if we add the src files back from the next version? At the moment we are after the release and unfortunately we cannot make such changes.

Regards

VDLP priority commented 2 years ago

Hello,

Can you make a hotfix with version 3.0.1? So we can use the datepicker fix in our project. This is a blocker for us.

Kind regards,

Van der Let & Partners

Mikołaj Smoleński staff commented 2 years ago

Actually, we will have to wait at least one week. Can you copy the files manually from the repository until we release a hot fix?

Regards

VDLP priority commented 2 years ago

That is fine if the hotfix will come soon. Can a hotfix also be issued for the calendar plugin? The source files seem to be missing there aswell.

Thanks in advance!

With kind regards,

Van der Let & Partners

Mikołaj Smoleński staff commented 2 years ago

Ok, we will remove npmignore in all repositories.

Regards

VDLP priority commented 2 years ago

Hi, is there any update on this?

With kind regards,

Van der Let & Partners

Bartosz Cylwik staff commented 2 years ago

Hi! We are currently working on some fixes, new tutorials and admin dashboards right now. We expect the next release to be on 24.10. Best Regards!